Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BankAccountOptions is not contained in a namespace. #1190

Closed
ghost opened this issue May 21, 2018 · 1 comment
Closed

BankAccountOptions is not contained in a namespace. #1190

ghost opened this issue May 21, 2018 · 1 comment
Assignees

Comments

@ghost
Copy link

ghost commented May 21, 2018

The following file defines the class BankAccountOptions at the root level. It shows up outside of the Stripe namespace, polluting the global namespace for the assembly.

Note: There appears to be another class that IS in the namespace.

stripe-dotnet\src\Stripe.net\Services_sources_token\BankAccountOptions.cs

Contents follow:

using Newtonsoft.Json;
using Stripe;

public class BankAccountOptions : INestedOptions
{
    [JsonProperty("bank_account")]
    public string TokenId { get; set; }

    [JsonProperty("bank_account[account_holder_name]")]
    public string AccountHolderName { get; set; }

    [JsonProperty("bank_account[account_holder_type]")]
    public string AccountHolderType { get; set; }

    [JsonProperty("bank_account[account_number]")]
    public string AccountNumber { get; set; }

    [JsonProperty("bank_account[country]")]
    public string Country { get; set; }

    [JsonProperty("bank_account[currency]")]
    public string Currency { get; set; }

    [JsonProperty("bank_account[routing_number]")]
    public string RoutingNumber { get; set; }
}
@remi-stripe
Copy link
Contributor

Thanks for the report, I opened a PR to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant