Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is Event.Created nullable? #1840

Closed
clement911 opened this issue Nov 15, 2019 · 4 comments
Closed

Why is Event.Created nullable? #1840

clement911 opened this issue Nov 15, 2019 · 4 comments

Comments

@clement911
Copy link
Contributor

Why is Event.Created nullable?

Also, is this in UTC or the machine timezone?
@remi-stripe
Copy link
Contributor

@clement911 created can be optional on some resources at the moment and I think it was optional on Event for a while a long time ago. It's not nullable today though so I'll push a fix and in the next major version it won't be nullable anymore.

As for the timestamps, our API always returns a unix timestamp so it would be UTC-based!

@remi-stripe remi-stripe mentioned this issue Nov 15, 2019
Merged
@remi-stripe
Copy link
Contributor

Okay the next major version (34.0.0) will have this fix. You can follow along in this PR: #1838

@clement911
Copy link
Contributor Author

Thank you @remi-stripe !
I'll leave it to up to you to close this issue.

@remi-stripe
Copy link
Contributor

Yes, I'll close the issue when the major version is released!

@Andrewangeta Andrewangeta mentioned this issue Dec 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clement911 @remi-stripe