Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card scanner does not support localisation of NSCameraUsageDescription #1745

Closed
glaures-ioki opened this issue Jan 8, 2021 · 2 comments
Closed

Card scanner does not support localisation of NSCameraUsageDescription #1745

glaures-ioki opened this issue Jan 8, 2021 · 2 comments
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@glaures-ioki
Copy link

Summary

Even after enabling card scanning on an iOS 14.3 device, the feature is not available. This is due to the way cardScanningAvailableCameraHasUsageDescription is implemented: it only looks for NSCameraUsageDescription in Bundle.main.infoDictionary.

Bundle.main.localizedInfoDictionary should be checked too.

Code to reproduce

Any project using a localised info.plist file instead of having NSCameraUsageDescription hardcoded in info.plist.

iOS version

14.3

Installation method

Carthage

SDK version

21.2.0
@davidme-stripe
Copy link
Contributor

davidme-stripe commented Jan 9, 2021 •
edited
Loading

Hi @glaures-ioki! Sorry about that, and thanks for the report. We'll fix this and release an update soon.

@davidme-stripe davidme-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Jan 9, 2021
@davidme-stripe
Copy link
Contributor

This was fixed in 21.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidme-stripe @glaures-ioki and others