-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: types of address attributes differ marginally #640
Comments
Thanks for highlighting this. I don't think there's meant to be a meaningful difference here, so I've raised with the team to take a look. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
This is a real nitpick but I still wanted to check: Is there a specific reason the properties on
AccountAddressParam
andAddress
are typed differently?If you take
line2
as an example it's typed asline2?: string
one time and asline2: string | null
another time. This means that we need to recast the address object we received from Stripe when we send it back to Stripe unchanged in order to make it type safe.Not a big deal, as I said but I was still curious. Thank you!
Environment
No response
Reproduction
No response
The text was updated successfully, but these errors were encountered: