Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: types of address attributes differ marginally #640

Open
SerafinDinges opened this issue Aug 27, 2024 · 2 comments
Open

[BUG]: types of address attributes differ marginally #640

SerafinDinges opened this issue Aug 27, 2024 · 2 comments
Labels
bug Something isn't working stale

Comments

@SerafinDinges
Copy link

What happened?

This is a real nitpick but I still wanted to check: Is there a specific reason the properties on AccountAddressParam and Address are typed differently?

If you take line2 as an example it's typed as line2?: string one time and as line2: string | null another time. This means that we need to recast the address object we received from Stripe when we send it back to Stripe unchanged in order to make it type safe.

Not a big deal, as I said but I was still curious. Thank you!

Environment

No response

Reproduction

No response

@SerafinDinges SerafinDinges added the bug Something isn't working label Aug 27, 2024
@brendanm-stripe
Copy link
Contributor

Thanks for highlighting this. I don't think there's meant to be a meaningful difference here, so I've raised with the team to take a look.

Copy link

stale bot commented Sep 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants