Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Stripe\JsonSerializable and bump minimum version to PHP 5.4 (or later) #406

Closed
twoixter opened this issue Dec 29, 2017 · 1 comment · Fixed by #412
Closed

Deprecate Stripe\JsonSerializable and bump minimum version to PHP 5.4 (or later) #406

twoixter opened this issue Dec 29, 2017 · 1 comment · Fixed by #412

Comments

@twoixter
Copy link

PHP version 5.3 is at End of Life cycle for at least 3 years now. The file ./lib/JsonSerializable.php as a bridge for the \JsonSerializable interface prevents execution of the AspectMock library for testing, apart from not being PSR-2 compliant.

AspectMock library from Codeception is a powerful mocking library we use to test static methods and mock objects but it parses PHP files on their own and doesn't recognise the special syntax used (interface declarations must be at root).

This issue is a suggestion to make the current version usable much like the v1.18.0 version for PHP 5.2, as specified in Legacy Version Support.

@ob-stripe
Copy link
Contributor

Hi @twoixter, thanks for this report. We've held off dropping support for PHP 5.3 and other post-EOL versions because a non-negligible part of Stripe users are still using those versions.

That said, I agree it's time we reconsider this position, at least for 5.3. We will discuss this internally once the new year break is over, but I'm leaving the issue open so that anyone can contribute to the discussion -- data points such as the AspectMock compatibility issue you mentioned are very valuable to us and will help us make an informed decision.

This was referenced Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants