Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined property of Stripe\Collection instance: _requestParams in 7.0.0 #727

Closed
RealityRipple opened this issue Sep 5, 2019 · 2 comments · Fixed by #728
Closed

Undefined property of Stripe\Collection instance: _requestParams in 7.0.0 #727

RealityRipple opened this issue Sep 5, 2019 · 2 comments · Fixed by #728

Comments

@RealityRipple
Copy link

Line 123 of lib\Collection.php seems to be entirely pointless, and throws a warning. Leftover code, I'm guessing?
@ob-stripe
Copy link
Contributor

Indeed, we (I) recently refactored this code in v7.0.0 and apparently forgot to remove this line. Will fix, thanks for the report!

@ob-stripe ob-stripe mentioned this issue Sep 5, 2019
Merged
@ob-stripe
Copy link
Contributor

Fixed in 7.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up Collection stripe/stripe-php
2 participants
@ob-stripe @RealityRipple