-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CardField crashes the app when it's focused and unmounted while using the new architecture (Fabric) #1732
Comments
Android does not even show the CardField with Fabric enabled. This is a huge issue since react native 76 which is coming out next month will have the new Architecture enabled by default which will make this library unusable at that point. @charliecruzan-stripe any update on supporting Fabric? |
@davidme-stripe @charliecruzan-stripe is there any update on this? New arch support appears to be landing soon and this is one issue we are seeing in our preparations. |
any update on this react native 0.76.0 was just released today with the New Arch turned on by default and this library does not work with it are you guys going to update it? |
any update? |
any update? |
1 similar comment
any update? |
any update ? This is very problematic |
did you solve it @aganov ? |
Try to create hidden input and focus on it before hide keyboard or close page. |
Is there a patch we can apply temporarily until this issue is resolved? @tjclawson-stripe @ianjabour-stripe @charliecruzan-stripe |
Faced the same issue, and its keeping us from migrating to new architecture. |
Any updates? |
Hi all, thanks for reporting. We're working on updating to the new architecture and will post an update when completed. |
Thank you, any timeline though? |
Any update on this? |
hi trying to implement add card functionality to react native app, the thing here its that only with navigation going back or closing the component where the CardField its inside whether is focused or has been focused once it crashes in auto the app. Tried using inside react navigation lib the method navigate.popToTop it still not working. |
is there any update on this, On ios my app crashes when I close the bottomSheet or navigate to another screen, and on android I'm not getting the cardDetails in the callback function onCardChange |
Using the new NEW_ARCH (Fabric), the app crashes with the error:
Swift runtime failure: force unwrapped a nil value + 0 [inlined] closure #1 in CardFieldManager.blur(_:) + 484
when the component containingCardField
is unmounted while theCardField
is focused.To Reproduce
Steps to reproduce the behavior:
CardField
component and compile the iOS app withRCT_NEW_ARCH_ENABLED=1
.CardField
.navigation.goBack
,bottomsheet.close
, etc.).Expected behavior
The app should dismiss keyboard and unmount the screen without crashing, even when the
CardField
is focused.Screenshots
N/A
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
This issue occurs only when using the new Fabric architecture with
RCT_NEW_ARCH_ENABLED=1
. I have not tested on Android yet, the issue may also be present there.The text was updated successfully, but these errors were encountered: