Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower case letters for Canadian postcodes in payment modal leads to an issue #494

Closed
semenetsvladislav opened this issue Aug 5, 2021 · 5 comments
Labels
blocked Don't start work on this until label is removed bug Something isn't working

Comments

@semenetsvladislav
Copy link

semenetsvladislav commented Aug 5, 2021

Describe the bug
Lower case letters for Canadian postcodes in payment modal leads to an issue
Found the same issue was here stripe/stripe-android#2302
The same behaviour we have in this module now

Expected behavior
We should capitalize Canadian postal codes.
Postal code shouldn't be invalid just because it's in lower case.

@semenetsvladislav
Copy link
Author

@arekkubaczkowski @thorsten-stripe any updates here? Will it be fixed in future?

@arekkubaczkowski
Copy link
Collaborator

@michelleb-stripe can you take a look on this?

@thorsten-stripe thorsten-stripe added blocked Don't start work on this until label is removed bug Something isn't working labels Aug 10, 2021
@semenetsvladislav
Copy link
Author

any progress here? @arekkubaczkowski @thorsten-stripe

@michelleb-stripe
Copy link
Contributor

@arekkubaczkowski In the latest release only US zip codes have postal code validation

@michelleb-stripe michelleb-stripe removed their assignment Oct 12, 2021
@charliecruzan-stripe
Copy link
Collaborator

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Don't start work on this until label is removed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants