Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader not discovered in handoff mode on S700 Devkit #788

Closed
rlfrahm opened this issue Aug 15, 2024 · 14 comments
Closed

Reader not discovered in handoff mode on S700 Devkit #788

rlfrahm opened this issue Aug 15, 2024 · 14 comments
Assignees

Comments

@rlfrahm
Copy link

rlfrahm commented Aug 15, 2024

Describe the bug

The following versions cause discoverReaders to never return a reader to connect to:

implementation("com.stripe:stripeterminal-core:3.8.0")
implementation("com.stripe:stripeterminal-handoffclient:3.8.0")

While 3.7.0 seems to work fine:

implementation("com.stripe:stripeterminal-core:3.7.0")
implementation("com.stripe:stripeterminal-handoffclient:3.7.0")

I also have this problem while using 0.0.1-beta.20 of this package:

...
"@stripe/stripe-terminal-react-native": "0.0.1-beta.20"
...

While 0.0.1-beta.19 works fine.

I'm using this issue as reference for how to setup handoff mode.

To Reproduce
Steps to reproduce the behavior:

  1. Install 0.0.1-beta.20 and build example-app
  2. Deploy example-app through Stripe on physical S700 Devkit
  3. Try to discover readers in handoff discovery mode
  4. No readers discovered

Expected behavior
It should discover readers in the latest version.

Screenshots
If applicable, add screenshots to help explain your problem.

Stripe Terminal React Native SDK version

  • ^0.0.1-beta.20

Smartphone (please complete the following information):

  • Device: S700 Devkit
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@rlfrahm
Copy link
Author

rlfrahm commented Aug 15, 2024

Updated my original description to change the Android package versions to 3.7.0 as that is the latest version that I can get to work.

@thelight413
Copy link

I having this issue even using a bluetooth reader.

@rlfrahm
Copy link
Author

rlfrahm commented Aug 15, 2024

@thelight413 are you using an S700 device or something else?

@thelight413
Copy link

I'm using my android phone and an android tablet. I was also having issues connecting to the reader even if it was discovered. But only on a fresh install, not when I restart the app.

@rlfrahm
Copy link
Author

rlfrahm commented Aug 15, 2024 via email

@thelight413
Copy link

@rlfrahm I even recreated the issue on the example app. I am using render as a backend.

@rlfrahm
Copy link
Author

rlfrahm commented Aug 19, 2024

I had the same intermittent troubles when getting started. It wasn't until I reached out to Stripe on their Discord that it finally started working at least partially. I'd recommend opening a ticket there: https://discord.com/invite/stripe

@thelight413
Copy link

@rlfrahm for your issue, did you wait till the sdk initialized?

@sunday-bernard-notarianni

Hello,
I have a similar issue using the Java/Kotlin SDK.

I get the following error message with the android sample app:

discoveryCallback onFailure
com.stripe.stripeterminal.external.models.TerminalException: RPC application error INVALID_REQUEST with message Invalid device_type: must be one of bbpos_wisepad3, stripe_m2, stripe_s700, bbpos_chipper2x, bbpos_wisepos_e, verifone_P400, simulated_wisepos_e, or mobile_phone_reader
    at com.stripe.stripeterminal.handoffclient.HandoffAidlRpcListener.onComplete(HandoffAidlRpcListener.kt:48)
    at com.stripe.core.aidlrpc.AidlRpcListener$Stub.onTransact(AidlRpcListener.java:74)
    at android.os.Binder.execTransactInternal(Binder.java:1021)
    at android.os.Binder.execTransact(Binder.java:994)

The error message seems to suggest that stripe_s700 are accepted for Handoff dicovery, but maybe not stripe_s700_devkit ?

@rlfrahm
Copy link
Author

rlfrahm commented Sep 3, 2024

@rlfrahm for your issue, did you wait till the sdk initialized?

Yes

@rlfrahm
Copy link
Author

rlfrahm commented Sep 3, 2024

Hello, I have a similar issue using the Java/Kotlin SDK.

I get the following error message with the android sample app:

discoveryCallback onFailure
com.stripe.stripeterminal.external.models.TerminalException: RPC application error INVALID_REQUEST with message Invalid device_type: must be one of bbpos_wisepad3, stripe_m2, stripe_s700, bbpos_chipper2x, bbpos_wisepos_e, verifone_P400, simulated_wisepos_e, or mobile_phone_reader
    at com.stripe.stripeterminal.handoffclient.HandoffAidlRpcListener.onComplete(HandoffAidlRpcListener.kt:48)
    at com.stripe.core.aidlrpc.AidlRpcListener$Stub.onTransact(AidlRpcListener.java:74)
    at android.os.Binder.execTransactInternal(Binder.java:1021)
    at android.os.Binder.execTransact(Binder.java:994)

The error message seems to suggest that stripe_s700 are accepted for Handoff dicovery, but maybe not stripe_s700_devkit ?

I've confirmed that with Stripe staff that the S700 devices should be in handoff mode and it's working for me now after downgrading versions. Are you by chance using production api keys or something? DevKit's only work in test mode.

@sunday-bernard-notarianni

I contacted my Stripe sales representative. He had to activate some flag in our stripe account to enable Apps on Devices. It works fine now. 🟢

@nazli-stripe
Copy link
Collaborator

@thelight413 i think your issue could be related to #789. Can you give it a try on the latest beta.21 release and let us know if that solves the issue?

it's working for me now after downgrading versions.
@rlfrahm is your issue related to Android version specifically? Have you tested with both Android and RN SDKs?

@nazli-stripe nazli-stripe self-assigned this Sep 17, 2024
@rlfrahm
Copy link
Author

rlfrahm commented Sep 24, 2024

@nazli-stripe I believe this is now resolved in beta.21.

@rlfrahm rlfrahm closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants