Add Sane Docker Default Config #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a Docker-specific config that doesn't enable any sinks at all, so users will only have to enable them.
Gerald Rule: Copy Observability on Veneur, Unilog, Falconer pull requestscc @stripe/observability |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Created a Docker-specific config file to disable all sinks in the base container.
Motivation
When you run the base container it defaults to enabling DataDog, which is not appropriate for all users. To work around this without creating your own fork of the container you have to pass in
VENEUR_DATADOGAPIKEY=""environment variables, which is just confusing if your org doesn't use DataDog in any capacity.Test plan
I built the Docker container from my branch and tested that it correctly fails to start unless a user has configured their data sinks.
Rollout/monitoring/revert plan
I assume this would just go through the normal CI build process for containers and eventually get released to Docker Hub
Fixes: #705