Losing context data

[pbalan]

Description/Steps to reproduce

I wrote a loopback component and all my tests are working with memory db.
However, when I change datasource to mongodb, I do not see the context data in operation hook.

1. clone the repo below.
2. npm test
3. git checkout test-mongo
4. npm test

Link to reproduction sandbox

https://github.com/pbalan/component-reproduce-error.git

Master Branch: runs with memory connector. TEST PASS

test-mongo Branch: runs with mongodb connector. TEST FAIL

Error thrown in source

Expected result

TEST PASS

Additional information

node -e 'console.log(process.platform, process.arch, process.versions.node)': darwin x64 8.9.4
npm ls --prod --depth 0 | grep loopback loopback-connector-mongodb@3.4.1

[pbalan]

@raymondfeng @bajtos @loay @dhmlau Any solution to this yet?

[bajtos]

@pbalan I am afraid the link https://github.com/pbalan/component-reproduce-error.git returns 404 to me. Is your repository perhaps private? Could you please make it public or at least grant me and my colleagues read access?

[pbalan]

@bajtos Sorry for the late response. I resolved this issue as it was not related to loopback context but appeared prima-facie.
I resolved the issue related to loopback-context on single model using local object previously to avoid loopback-context altogether.

However, I again stumbled on the same problem today. Am trying to get loopback context inside middleware. @matt-landers solution doesn't work for me on
loopback@3.18.2.
loopback-connector-mongodb@3.4.1

[pbalan]

Previously, I had implemented a before delete and after delete operation hook through hookstate.
The solution to the above specific problem was to override remote method.

const deleteById = Model.deleteById;

Model.deleteById = (id, cb) => {
  Model.updateAll({id: id}, {
    deletedAt: new Date(),
    deletedBy: cb.accessToken.userId,
  }, cb);
};

[bajtos]

@pbalan sorry, I have no idea how to reproduce the problem you are experiencing, therefore I am not able to help you.

However, I noticed a suspicious thing in your code example - you are treating cb as an options object. I think the following code should work better for you:

Model.deleteById = (id, options, cb) => {
  Model.updateAll({id: id}, {
    deletedAt: new Date(),
    deletedBy: options.accessToken.userId,
  }, cb);
};

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.