[SEMVER-MAJOR] Always use bluebird as the Promise implementation

[jannyHou]

This pr is created for updating files to use bluebird as promise library.
Details see here:
Connect to strongloop-internal/scrum-loopback#615

Related: strongloop/loopback#1896

[bajtos]

Hi @jannyHou, I guess this is a good start. Now you need to clean up createPromiseCallback. We no longer depend global.Promise, thus there is no need to check if it's defined. Also please move bluebird from devDependencies to dependencies.

[bajtos]

Also remove these three lines and make sure tests are still passing on Node v0.10: https://github.com/strongloop/loopback-datasource-juggler/blob/1e9bbd27873077ef374ea5487121a70173757364/test/init.js#L30-L32

[jannyHou]

Hi @bajtos , I fixed 2 of 3 failures, and now tests pass on node v.10. Actually the third one is an unhandled error msg instead of a failure(at least mocha doesn't count it), and I get the same error when I run the code cloned from master branch. I guess it's not caused by my change but I'll see how to fix it(because it seems related to promise).

I commented if (!global.Promise) { //DoCheck } instead of delete, since I am not sure do we still need some check for promise library, I mean bluebird.

And I created a list of promisified apis whose doc might need update:
https://github.com/strongloop-internal/scrum-loopback/issues/615#issuecomment-165314984

Thanks!

[bajtos]

While you are making this change, could you please upgrade Bluebird to 3.x?

[bajtos]

I fixed 2 of 3 failures, and now tests pass on node v.10. Actually the third one is an unhandled error msg instead of a failure(at least mocha doesn't count it), and I get the same error when I run the code cloned from master branch. I guess it's not caused by my change but I'll see how to fix it(because it seems related to promise).

The new code looks right.

I commented if (!global.Promise) { //DoCheck } instead of delete, since I am not sure do we still need some check for promise library, I mean bluebird.

No need to keep that code in, we will always have the promise library as long as Node handles dependencies correctly (which is safe to assume).

And I created a list of promisified apis whose doc might need update:
strongloop-internal/scrum-loopback#615 (comment)

👍

[bajtos]

Please remove the trailing empty line (L29) too.

[bajtos]

@jannyHou code changes LGTM. Please rebase your patch on top of the current master and add an entry to https://github.com/strongloop/loopback-datasource-juggler/blob/master/3.0-RELEASE-NOTES.md

The idea is write a short text explaining loopback users (developers) what this change means for their applications and provide instructions how to upgrade.

@superkhau could you please help here?

[bajtos]

The idea is write a short text explaining loopback users (developers) what this change means for their applications and provide instructions how to upgrade.

Also include a link to this pull request to make it easy to look up more details if needed in the future.

[bajtos]

Please keep line width at 80 characters max, it makes it easier to review diffs.

[bajtos]

@jannyHou One more minor comment to address. Once you address it, please go ahead and land the PR without waiting for another review.