-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8::ObjectTemplate::Set() with non-primitive values is deprecated #67
Comments
Can you check what version of |
Looks like version 2.3.5:
|
FWIW, I don't get warnings with node.js v6.2.1 and nan 2.3.5. Can you |
I can, but as I said in the initial issue, I've done that already.. From the attachment:
Does that not imply that there is something in oracle_bindings that is the culprit? Or is the error too vague such that the error points to a different package being includes? |
Yes, it's originating from oracle_bindings.node but it's really a nan issue, one I fixed in nodejs/nan#560 and that was released in nan@2.3.0. |
Ok, so I just blew away the directory, and had success. It's strange when I did this yesterday and the build failed. This time for success I had to:
I'll try a couple more iterations, but the build process should be without this sort of hiccup. Hopefully it's not just me. Thanks for the help.. |
I've seen this floating around the internet as a reference to fsevents. However I am still seeing this set of warnings now that I am using the master release after working on my PR branch for so long.
These do seem to be warnings, and could potentially be turned off. However, I imagine they are easy fixes.
Steps take/configuration:
strong oracle object template warnings.txt
The text was updated successfully, but these errors were encountered: