You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I encountered an error using Strophe in Workers, compiled as a dependency. It appears that the method Builder.up() is using this.node = this.node.parentElement; but in this particular context, node.parentElement does not exists.
I patched it locally, replacing it by node.parentNode and it seems to work.
I don't know if it would have side effects to change it directly.
Let me know if you need a PR.
Best regards
The text was updated successfully, but these errors were encountered:
Hi, I would appreciate a PR, thanks. I think for backwards compatibility, the code could use parentElement if it's available and fall back to using parentNode if not.
Hello,
I encountered an error using Strophe in Workers, compiled as a dependency. It appears that the method
Builder.up()
is usingthis.node = this.node.parentElement;
but in this particular context,node.parentElement
does not exists.I patched it locally, replacing it by
node.parentNode
and it seems to work.I don't know if it would have side effects to change it directly.
Let me know if you need a PR.
Best regards
The text was updated successfully, but these errors were encountered: