Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karma runner: handle preprocessor errors from karma-webpack #1837

Closed
nicojs opened this issue Nov 11, 2019 · 1 comment
Closed

Karma runner: handle preprocessor errors from karma-webpack #1837

nicojs opened this issue Nov 11, 2019 · 1 comment
Labels
🐛 Bug Something isn't working ☠ stale Marked as stale by the stale bot, will be removed after a certain time.

Comments

@nicojs
Copy link
Member

nicojs commented Nov 11, 2019

Preprocessor magic in karma is doing more stuff nowadays. For example, the karma-webpack plugin runs entire webpack. Whenever an error is thrown, it is often logged to the console and proceeded, like business as usual. In karma-webpack's case, this means a timeout, because karma is blocked until the next succesful bundle.

In order to fix this issue, these 2 things need to be fixed first:

  1. The karma-webpack plugin doesn't handle errors properly. Instead of reporting preprocessor errors to karma, it just logs it to console and proceeds:
    https://github.com/webpack-contrib/karma-webpack/blob/3cc35b33e14405e65b8f91505f212b0b035f8cc0/src/karma-webpack.js#L130-L139
  2. Even if the karma-webpack plugin would report the error properly, karma wouldn't handle it properly. I've opened an issue here: Runner middleware does not handle file-list rejections karma-runner/karma#3396
@nicojs nicojs added the 🐛 Bug Something isn't working label Nov 11, 2019
@stale
Copy link

stale bot commented Nov 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the ☠ stale Marked as stale by the stale bot, will be removed after a certain time. label Nov 20, 2020
@stale stale bot closed this as completed Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working ☠ stale Marked as stale by the stale bot, will be removed after a certain time.
Projects
None yet
Development

No branches or pull requests

1 participant