Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files and folders with emoji in their paths are ignored by Stryker #2418

Closed
Lakitna opened this issue Aug 25, 2020 · 1 comment · Fixed by #2430
Closed

Files and folders with emoji in their paths are ignored by Stryker #2418

Lakitna opened this issue Aug 25, 2020 · 1 comment · Fixed by #2430
Labels
🐛 Bug Something isn't working
Milestone

Comments

@Lakitna
Copy link
Contributor

Lakitna commented Aug 25, 2020

Summary

I ran into this in #2417

Express has test fixtures: https://github.com/expressjs/express/tree/master/test/fixtures

These fixtures have to be copied to the sandbox for the tests to pass. So far so good. Notice that the /snow folder has an emoji in it. This causes Stryker to ignore the folder and thus not copy the file to the sandbox. This causes the initial test run to fail.

I've looked a bit further, and this is also the case for file names with emojis in them. All other files are copied to the sandbox as expected.

Now, this is a pretty obscure bug, but emoji paths are fully supported by Windows, and probably other OSs as well. Still, I'm not sure if it's worth fixing this.

Stryker config

= default init with CommonJS + Mocha

/**
 * @type {import('@stryker-mutator/api/core').StrykerOptions}
 */
module.exports = {
  logLevel: 'debug',
  "mutator": "javascript",
  "packageManager": "npm",
  "reporters": [
    "html",
    "progress"
  ],
  "testRunner": "mocha",
  "transpilers": [],
  "testFramework": "mocha",
  "coverageAnalysis": "perTest"
};

Test runner config

See https://github.com/expressjs/express

Stryker environment

    "@stryker-mutator/core": "^3.3.1",
    "@stryker-mutator/javascript-mutator": "^3.3.1",
    "@stryker-mutator/mocha-framework": "^3.3.1",
    "@stryker-mutator/mocha-runner": "^3.3.1",

See for test runner deps: https://github.com/expressjs/express

Test runner environment

See https://github.com/expressjs/express

Your Environment

software version(s)
node 14.5.0
npm 6.14.5
Operating System Windows 10

Add stryker.log

Note the absence of /snow

stryker.log

@Lakitna Lakitna added the 🐛 Bug Something isn't working label Aug 25, 2020
@nicojs nicojs added this to the 4.0 milestone Aug 25, 2020
@nicojs
Copy link
Member

nicojs commented Aug 25, 2020

😁⛄😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants