-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test runner process ran out of memory #2641
Comments
Thanks for opening this issue. Why did you conclude it is an out-of-memory (OOM) error? I don't see this explicitly. |
because it said so here:
|
Ah yes, sorry, didn't read the log properly 😅 Interesting will take a look. |
From quick testing, it looks like the way the instrumentor takes care of string concatenation is by recognizing the concat operator ( I believe that we should be able to solve this by trying to detect when a binary expression is a string concatenation rather than an arithmetic operation. We can do this by walking through the entire |
I was expecting that to happen internally. Good to hear that you are already working on it. |
I would say solving the OOM error for this particular case can be a side effect of #2646. The root cause of the OOM error can hopefully be found and solved at https://github.com/stryker-mutator/stryker/blob/f3a177df401ed252401643ddc87d45f21ab071ee/packages/instrumenter/src/mutant-placers/expression-mutant-placer.ts#L53 |
@jonathan-dev quite a lot has changed since December. Notably, since 5.2 we've improved our mutant placing algorithm. Are you still experiencing OOM errors? |
I see, the ticket is still in opened status but the concatenation probably was fixed in #2648 |
Yes definitely. We've also since fixed the root cause in #2964 @DanielLepszy thanks for pointing that out 🙏 |
Summary
I found the way I implemented a string concatenation function causes stryker to run out of memory.
function causing the problem:
error produced:
changing the function to this fixes the problem:
but since it is undesirable to have to do those kinds of refactorings I wanted to file a bug report.
Stryker config
Test runner config
default
Stryker environment
Test runner environment
# Test command stryker run
Your Environment
Add stryker.log
The text was updated successfully, but these errors were encountered: