Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Range from Mutant api #2812

Closed
nicojs opened this issue Mar 19, 2021 · 1 comment
Closed

Remove Range from Mutant api #2812

nicojs opened this issue Mar 19, 2021 · 1 comment
Assignees
@simondel
Labels
🔧 Maintenance Maintenance issue
Milestone
5.0

Comments

@nicojs
Copy link
Member

nicojs commented Mar 19, 2021

Range should be removed:

https://github.com/stryker-mutator/stryker/blob/acb0a3a3ddf8e82ffbae7212538fd0bba4802944/packages/api/src/core/mutant.ts#L17-L21

It is inconsistent with our JSON report. If we want to support --incremental ( #2753 ), we need to remove it.

This is a breaking change for our API. So should be in v5
@nicojs nicojs added the 🔧 Maintenance Maintenance issue label Mar 19, 2021
@nicojs nicojs added this to the 5.0 milestone Mar 19, 2021
@simondel simondel self-assigned this Apr 2, 2021
@nicojs
Copy link
Member Author

nicojs commented May 12, 2021

Closed with #2882

@nicojs nicojs closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simondel simondel

Labels
🔧 Maintenance Maintenance issue
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@nicojs @simondel