Implement hit counter in the jasmine-runner #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2021
nicojs
requested changes
Oct 15, 2021
packages/jasmine-runner/test/integration/timeout-on-infinite-loop.it.spec.ts
Outdated
Show resolved
Hide resolved
fredericbonnet
force-pushed
the
feat/hit-counter-jasmine
branch
from
e367443 to
871782b
Compare
nicojs
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #3173 :
testin packagejasmine-runner)testande2erespectively)The only issue that I could not solve is Mocha not detecting loop timeout in the integration test suite (file
packages/jasmine-runner/test/integration/timeout-on-infinite-loop.it.spec.ts, the offending test is marked as.skip). I tried changing the timeout options at many places (test, runner, options file, command line, etc) but to no avail. Despite that, the overall behavior seems correct.