feat(mutators) Avoid creating some unnecessary mutators for (a && b) …

[edi9999]

Fix #3339

Will be adding a few comments inline

Before:

- if (a && b) {}
+ if (false) {}
+ if (false && b) {}
// And others

- if (a || b) {}
+ if (true) {}
+ if (true && b) {}
// And others

After:

- if (a && b) {}
+ if (false) {}
// And others

- if (a || b) {}
+ if (true) {}
// And others

[nicojs]

Looks incredibly simple if you put it like this 🙂

Got some small remarks. Also CI is failing

[edi9999]

@nicojs about the failed test, I had written the following in an autoreview ( I don't know if you can see it, I am not used to github reviews).

This test is not passing,

c1 || c2 || c3 is, as the current state in master, generating only those mutators :

if (true), if (false), if(true || c3), if (false || c3)

It should in my opinion generate those mutants instead;

if (true), if (false), if(false || c2 || c3), if (c1 || false || c3), if (c1 || c2 || false)

This is I think linked to the fact that babel will parse a "3-way" boolean operation as two separate nested || operations.

In this test, I could see that the condition if (isBooleanExpression(path)) { is actually just hit once.

Maybe this test should simply be removed from this pull request, and a new issue created for this issue.

[nicojs]

Maybe this test should simply be removed from this pull request, and a new issue created for this issue.

Yes, that's probably best. Probably a good idea to discuss it in a separate issue as well, as I think the test cases are already covered largely by the logicalOperatorMutator

[edi9999]

@nicojs is there a way to update the e2e tests quickly ?

I'm running :

npm run e2e

Since it stops after the first fail, I have to manually relaunch the tests and copy paste the output.

[nicojs]

You can run them manually by running npm test in an e2e/test/xxx directory. But every time you change something in Stryker, you need to reinstall with npm install from the e2e root dir

[edi9999]

Tests are now passing, can you please review @nicojs ?

[nicojs]

LGTM 👍