Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability in log4js dependency #3373

Closed
ericcornelissen opened this issue Jan 21, 2022 · 2 comments · Fixed by #3372
Closed

Vulnerability in log4js dependency #3373

ericcornelissen opened this issue Jan 21, 2022 · 2 comments · Fixed by #3372
Labels
🔧 Maintenance Maintenance issue

Comments

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Jan 21, 2022

Is your maintenance request related to a problem? Please describe.
A CVE was published for log4js, leading npm audit, Snyk, and I'm sure other security tools to raise concerns about it through the Stryker-js core package (and possibly others, I didn't check).

Now, I don't think this vulnerability is a real concern for Stryker users, nevertheless I think it's worth updating - even if just to err on the safe side.

Describe the solution you'd like
Update log4js to a recommended version, i.e. 6.4.0 or higher.

Describe alternatives you've considered
End-users can ignore the CVE, I don't think that's a good idea if it's not necessary. In this case, updating the vulnerable dependency should be straightforward as no major version bump is required for the fix.

Additional context
References:

@ericcornelissen ericcornelissen added the 🔧 Maintenance Maintenance issue label Jan 21, 2022
@nicojs
Copy link
Member

nicojs commented Jan 22, 2022

Thanks for reaching out. We have been experiencing issues with upgrading log4js for some time, see log4js-node/log4js-node#1037. But this issue bumps the priority to the top (priority of my spare time I can spend on my open source endeavours ;)).

@nicojs
Copy link
Member

nicojs commented Jan 23, 2022

Fixed in v5.6.1

$ npm i -D @stryker-mutator/core

added 185 packages, and audited 186 packages in 12s

30 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 Maintenance Maintenance issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants