feat(disableTypeChecks): add option 'true' to disable all type checks #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicojs
requested changes
Oct 4, 2022
There was a problem hiding this comment.
This looks pretty elegant. But it is not working.
If you change this:
diff --git a/e2e/test/typescript-transpiling/stryker.conf.json b/e2e/test/typescript-transpiling/stryker.conf.json
index 77b352b0..b7fdea85 100644
--- a/e2e/test/typescript-transpiling/stryker.conf.json
+++ b/e2e/test/typescript-transpiling/stryker.conf.json
@@ -8,6 +8,7 @@
"checkers": ["typescript"],
"tsconfigFile": "tsconfig.json",
"buildCommand": "npm run build",
+ "disableTypeChecks": true,
"plugins": [
"@stryker-mutator/mocha-runner",
"@stryker-mutator/typescript-checker"And run npm test there you get a bunch of these warnings:
07:52:14 (9921) WARN DisableTypeChecksPreprocessor Unable to disable type checking for file "/home/nicojs/github/stryker-js/e2e/test/typescript-transpiling/package.json". Shouldn't type checking be disabled for this file? Consider configuring a more restrictive "disableTypeChecks" settings (or turn it completely off with `false`) Error: Unable to parse /home/nicojs/github/stryker-js/e2e/test/typescript-transpiling/package.json. No parser registered for .json!
I think we should silently ignore files that cannot be parsed from packages/instrumenter/src/disable-type-checks.ts, that makes the most sense 🤷♀️
Maybe we want to create an e2e test for it? Or change one of our e2e tests to use true and verify no warnings are logged.
|
@simondel are you planning to pick up the last remark as well? 😇 |
nicojs
approved these changes
Oct 28, 2022
|
I've implemented it during hacktoberfest 🐱👤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3741
Adds option 'true' to the
disableTypeChecksconfig option to disable all type checks