Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File discovery of @stryker-mutator/tap-runner requires glob #4224

Closed
nicojs opened this issue May 24, 2023 · 0 comments · Fixed by #4225
Closed

File discovery of @stryker-mutator/tap-runner requires glob #4224

nicojs opened this issue May 24, 2023 · 0 comments · Fixed by #4225
Labels
🐛 Bug Something isn't working
Milestone

Comments

@nicojs
Copy link
Member

nicojs commented May 24, 2023

Summary

The current default file globbing of the tap-runner takes a very long time when there is a node_modules directory.

There also seems to be a { without a }:

- {**/@(test|tests|__test__|__tests__)/**,**/*.@(test|tests|spec)}.@(cjs|mjs|js|jsx|ts|tsx)

Ah no, the problem was that glob was not a dependency of @stryker-mutator/tap-runner. This meant another version of glob was required in the e2e test, which has a breaking change (promisified API). Adding a dependency on glob should fix this issue.

See test/e2e-tap branch: e2e/test/tap-old-version.

@nicojs nicojs added the 🐛 Bug Something isn't working label May 24, 2023
@nicojs nicojs added this to the 7.0 milestone May 24, 2023
@nicojs nicojs changed the title File discovery of @stryker-mutator/tap-runner takes node_modules into account. File discovery of @stryker-mutator/tap-runner requires glob May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant