Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type-checking): disable type check by default #4246

Merged
merged 1 commit into from
May 31, 2023

Conversation

nicojs
Copy link
Member

@nicojs nicojs commented May 31, 2023

Change the default of disableTypeChecks to true.

Closes #4204

@nicojs nicojs enabled auto-merge (squash) May 31, 2023 09:05
@nicojs nicojs merged commit d45350a into master May 31, 2023
@nicojs nicojs deleted the feat/disable-type-checks-default branch May 31, 2023 10:57
@SchroederSteffen
Copy link

SchroederSteffen commented Jun 5, 2023

Small hint: The docs need to be updated.

### `disableTypeChecks` [`boolean` | `string`]
Default: `"{test,src,lib}/**/*.{js,ts,jsx,tsx,html,vue}"`<br />
Command: _none_<br />
Config file: `"disableTypeChecks": false`
Set to 'true' to disable type checking, or 'false' to enable it. For more control, configure a pattern that matches the files of which type checking has to be disabled. This is needed because Stryker will create (typescript) type errors when inserting the mutants in your code. Stryker disables type checking by inserting `// @ts-nocheck` atop those files and removing other `// @ts-xxx` directives (so they won't interfere with `@ts-nocheck`). The default setting allows these directives to be stripped from all JavaScript and friend files in `lib`, `src` and `test` directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the default of disableTypeChecks
2 participants