feat(clear-text-reporter): Adds a "skipFull" option #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected an oversight in the newly added test case and added another one, to ensure that the report is skipped when each file has reached a score of 100%.
sebiniemann
changed the title
|
Thanks, @sebiniemann. I'm sorry it took me so long to merge it. Fixed some issues and merged it. |
@nicojs Many thanks for that, and I can fully understand if it takes longer, especially when it's voluntary work on free and open source software. A big thank you for your work on this great project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4690
I wasn't sure where you wanted these changes, so I've tried to be minimally invasive while covering everything mentioned in the issue:
Hopefully all pipeline tests and validations proceed smoothly, but we'll see how it goes :)