Skip to content

Commit

Permalink
fix(string-literal-mutator): don't mutate class property keys (#2544)
Browse files Browse the repository at this point in the history
Don't mutate class property keys that are written as a string literal.

```ts
class Foo { 
  'bar-baz': 4 // don't mutate
}
```
  • Loading branch information
nicojs authored Oct 8, 2020
1 parent 84bda32 commit 8c8b478
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export class StringLiteralMutator implements NodeMutator {
types.isExpressionStatement(parent) ||
types.isTSLiteralType(parent) ||
(types.isObjectProperty(parent) && parent.key === child.node) ||
(types.isClassProperty(parent) && parent.key === child.node) ||
(types.isCallExpression(parent) && types.isIdentifier(parent.callee, { name: 'require' }))
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ describe('instrumenter integration', () => {
it('should be able to instrument switch case statements (using the switchCaseMutantPlacer)', async () => {
await arrangeAndActAssert('switch-case.js');
});
it('should be able to instrument string literals in different places', async () => {
await arrangeAndActAssert('string-mutations.ts');
});

describe('type declarations', () => {
it('should not produce mutants for TS type definitions', async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ describe(StringLiteralMutator.name, () => {
it('should still mutate inside object property values', () => {
expectJSMutation(sut, 'const foo = { bar: "baz" };', 'const foo = { bar: "" };');
});
it('should not mutate class property keys', () => {
expectJSMutation(sut, 'class Foo { "baz-bar" = 4; }');
});
it('should mutate class property values', () => {
expectJSMutation(sut, 'class Foo { bar = "4"; }', 'class Foo { bar = ""; }');
});
});

describe('jsx', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
require('foo'); // no mutation
import 'foo'; // no mutation

class Foo {
public 'bar-baz': string; // no mutation
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`instrumenter integration should be able to instrument string literals in different places 1`] = `
"require('foo'); // no mutation
import 'foo'; // no mutation
class Foo {
public 'bar-baz': string; // no mutation
}"
`;

0 comments on commit 8c8b478

Please sign in to comment.