fix(StrykerTempFolder): Use local tmp folder #121
Conversation
When running mocha tests, we need to be able to resolve the local node_modules. The way this works in npm is that it searches for a node_modules in de current working directory. If not found, check the dir above. Etc. By creating the tmp-folder's locally, node_,modules will be resolved as expected.
|
When will this folder be removed form the file system? We can assume that a temp folder will (eventually) be cleared, but this is not the case for other locations such as your project folder. |
|
Hmm that's true. Haven't thought about the cleaning ♻️ What's your suggestion? I think we can just clear the entire StrykerTempFolder after stryker is done. But we could also make each individual part responsible for cleaning its own stuff. |
|
I would use a 'fire and forget' method for saving files. I don't believe that classes such as the TestRunnerOrchestrator should care if they make a mess in the StrykerTempFolder. I would let Stryker remove the temp folder before it exits. One disadvantage of the StrykerTempFolder is that it will exist if users kill Stryker, but by making Stryker just delete the entire folder after a run, a cleanup will still happen. |
|
Agreed. I'll implement that in this branch. You always run the risk of having temp-files remain if you kill the process, that's totally acceptable. One additional disadvantage is that you cannot run multiple instances of Stryker at one time anymore, because the one that is the first to close will clean all files. But i don't think its a big issue. |
|
@simondel we should first merge pull request 116 into master, that one contains fileUtils to easily clean a folder recursively. |
|
I just added the cleaning of the folder ♻️ ! |
* fix(StrykerTempFolder): Use local tmp folder When running mocha tests, we need to be able to resolve the local node_modules. The way this works in npm is that it searches for a node_modules in de current working directory. If not found, check the dir above. Etc. By creating the tmp-folder's locally, node_,modules will be resolved as expected. * fix(stryker-temp): Clean temp folder * fix(delete-dir): Fix for deleting a dir recrusive
When running mocha tests, we need to be able to resolve the local node_modules. The way this works in npm is that it searches for a node_modules in de current working directory. If not found, check the dir above. Etc. By creating the tmp-folder's locally, node_,modules will be resolved as expected.