-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update progress reporters to show timed out test count #1818
update progress reporters to show timed out test count #1818
Conversation
448f7c6
to
dfede95
Compare
Thanks for adding this! Could you also add a test to prove that the counting work? (That way we know it will continue to work :) ) |
…nto progress-show-timed-out
and update the killed mutant test to use thousand second mock timeout
Coming up, gonna merge from master first.
+1 (+100) |
The CI / e2e build seemed to go red after merging from master. The same thing happened to me yesterday, and it went away when I did a rebase. I just pushed a test update, will do another rebase if the build is still red. |
Thanks for the quick review and merge. Any idea when we can get this published? It would really help us (me) with mutation testing on Prettier. |
I'm hoping to release it this evening, but I'm having some issue with the release pipeline :( |
That's really fast, thanks:) |
Deployed as 2.2.1: https://travis-ci.org/stryker-mutator/stryker/jobs/608425051?utm_medium=notification&utm_source=github_status npmjs.org may take a while to index the new version. Manually updating should already work. The release of 2.2.0 to npm failed. It was only deployed to GitHub due to a poor solution I picked in an attempt to fix the release pipeline. |
I saw 2.2.1 on npmjs.com pretty quickly. I updated my branch in prettier/prettier#6681, tried it with and without "append-only" reporter, seems to work perfectly now. Thanks again @simondel! |
It can be extremely useful to see if there are any test timeouts going on when starting a long-running Stryker test run.
I have been working on using Stryker on Prettier (see prettier/prettier#6681) where test timeouts seem to be more likely if I do not adjust the
timeoutMS
setting (instryker.conf.js
).The source code changes seemed to be quite straightforward; a slightly more challenging part was to update the existing tests scripts to pass with these changes.
I did try these changes in my workarea and it seems to work with both default console "progress" reporter and "progress-append-only" reporter. (It seems to downgrade if I would pipe
stryker run
through thetee
utility.)Here is some initial output with the console "progress" reporter (I forget if I used an adjusted
timeoutMS
setting or not):and with the "progress-append-only" reporter (I forget if I used an adjusted
timeoutMS
setting or not):I would be extremely grateful if the owners & maintainers would consider getting these changes reviewed, merged, and released in the near future. Installation from npm would be so much easier than GitHub or local workarea, especially when integrating with a larger project such as Prettier. I wonder if would make sense to publish with special npm tag such as "rc"?
I do think it would be nice if we could unit test these updates somehow. The existing test suite does not seem to test these progress reporters so extensively at this point. Unfortunately I also cannot promise when I can work on these due to some other priorities at this time.