fix(InputFileResolver): Don't exclude all files #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename current progress-reporter to dots-reporter - Add new fancy progress-reporter
- Check currentFiles is not an empty array - Check if filePath is not a directory (/core.js/dist/vender/core.js)
* Add test for exclusion of file when the expression resolves in empty * Test that globbing only results in files, not directories.
- ProgressReporter
avassem85
reviewed
Dec 30, 2016
| return Promise.all([this.previous.resolve(), globbingTask]).then(results => { | ||
| const previousFiles = results[0]; | ||
| const currentFiles = results[1]; | ||
| // If this expression started with a '!', exclude current files | ||
| if (this.ignore) { | ||
| return previousFiles.filter(previousFile => currentFiles.some(currentFile => previousFile.path !== currentFile.path)); | ||
| return previousFiles.filter(previousFile => currentFiles.every(currentFile => previousFile.path !== currentFile.path)); |
There was a problem hiding this comment.
Why does every work better than some. Can you explain that?
There was a problem hiding this comment.
When an expression starts with a ! (and needs to ignore all matching files), then every file resulting from the current globing expression should not match to any of the current files. every makes sure of that.
For example:
previousFiles: ['file1', 'file2', 'expectedFile']currentFiles: ['file1', 'file2', 'somefile']- Expected result:
'expectedFile'
For an empty array, every returns true. More info: https://developer.mozilla.org/nl/docs/Web/JavaScript/Reference/Global_Objects/Array/every
There was a problem hiding this comment.
Ok, thanx for the explanation. De rest of the code seems good.
|
Thanks for reviewing! I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop excluding of all files when a globing expression starts with a
!and not results in files.