fix(mocha framework): Select tests based on name #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select tests in the `MochaTestFramework` based on it's name, rather than the order in which it is added to a test suite. * Change TestFramework interface to now filter based on test `id` and `name`. * Add `TestSelection` which represents a selected test using `id` and `name`. * Update `JasmineTestFramework` to now use the new `TestSelection` format (still based on ID). * Update `MochaTestFramework` to use the title to select tests. Fixes #249 BREAKING CHANGES: * Change api of `TestFramework`. It now provides an array of `TestSelection` objects, instead of an array of numbers with test ids.
Move code coverage intrumentation to a transpiler so we can handle the code transformation as all other transpilers. Simplifies the process by eliminating the need for keeping a seperate transformation process. Aso gets rid of the streaming api, so no need to know that part about node internals anymore.
|
Probably also fixes #291 |
simondel
reviewed
Oct 16, 2017
| expect(result[2].fullName).eq('outer test 3'); | ||
| }); | ||
|
|
||
| function filter(testIds: number[]) { |
There was a problem hiding this comment.
Do you ever pass anything other than a single number? If you don't won't it be easier to just allow one test id?
There was a problem hiding this comment.
Good point. I've added a test where we filter 2 tests just to make sure it works.
| realAddTest.apply(this, arguments); | ||
| } | ||
| current++; |
There was a problem hiding this comment.
You've removed this line but the declaration is still there. We can remove it right?
There was a problem hiding this comment.
Good point. I'll remove it.
| expect(result.passes[0].fullTitle).eq('outer inner test 3'); | ||
| }); | ||
|
|
||
| function filter(testIds: number[]) { |
There was a problem hiding this comment.
The same filter comment for the Jasmine test applies here
There was a problem hiding this comment.
Good point. I've added a test where we filter 2 tests just to make sure it works.
nicojs
added a commit
that referenced
this pull request
Jan 9, 2018
Support running mocha tests in Karma. It basically already worked since #413, just remove the old measures we set in place.
simondel
pushed a commit
that referenced
this pull request
Jan 12, 2018
Support running mocha tests in Karma. It basically already worked since #413, just remove the old measures we set in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select tests in the
MochaTestFrameworkbased on it's name, rather than the order in which it is added to a test suite.idandname.TestSelectionwhich represents a selected test usingidandname.JasmineTestFrameworkto now use the newTestSelectionformat (still based on ID).MochaTestFrameworkto use the title to select tests.JasmineTestFrameworkandMochaTestFrameworkto prevent this sort of thing from happening in the future.Fixes #249
BREAKING CHANGES:
TestFramework. It now provides an array ofTestSelectionobjects, instead of an array of numbers with test ids.