creates ModelTransformerTest

fixes ModelTransformer

Author: Cyril Mizzi

src/Transformer/Type/ModelTransformer.php

@@ -154,16 +154,25 @@ private function getFields(Model $model) {
 	 * @return callable
 	 */
 	private function getResolver(array $relation) {
-		$method = $relation['field'];
+		$method  = $relation['field'];
+		$primary = $this->app->make($relation['model'])->getKeyName();
+		$order   = array_flip(array_keys($this->getArguments()));
 
-		return function($root, array $args) use ($method) {
-			$collection = $root->{$method};
+		return function($root, array $args) use ($method, $primary, $order) {
+			// Clone collection in order to not erase existin collection
+			$collection = clone $root->{$method};
+
+			// We have to specific custom order to args because we cannot take
+			// some elements before splicing it...
+			uksort($args, function($key) use ($order) {
+				return $order[$key];
+			});
 
 			foreach ($args as $key => $value) {
 				switch ($key) {
 					case 'after'  : $collection = $collection->where($primary, '>', $value) ; break;
 					case 'before' : $collection = $collection->where($primary, '<', $value) ; break;
-					case 'skip'   : $collection = $collection->skip($value)                 ; break;
+					case 'skip'   : $collection = $collection->splice($value)               ; break;
 					case 'take'   : $collection = $collection->take($value)                 ; break;
 				}
 			}
@@ -174,7 +183,7 @@ private function getResolver(array $relation) {
 
 	/**
 	 * Return available arguments (many because there's no argument for single
-	 * element)
+	 * element). Order matter
 	 *
 	 * @return array
 	 */

tests/Transformer/ModelTransformerTest.php

@@ -0,0 +1,90 @@
+<?php
+namespace StudioNet\GraphQL\Tests\Transformer;
+
+use StudioNet\GraphQL\Tests\Entity;
+use StudioNet\GraphQL\Tests\TestCase;
+use StudioNet\GraphQL\Transformer\Type\ModelTransformer;
+use StudioNet\GraphQL\Type\EloquentObjectType;
+
+/**
+ * ModelTransformerTest
+ *
+ * @see TestCase
+ */
+class ModelTransformerTest extends TestCase {
+	/**
+	 * testSupports
+	 *
+	 * @return void
+	 */
+	public function testSupports() {
+		$transformer = $this->app->make(ModelTransformer::class);
+
+		$this->assertTrue($transformer->supports($this->app->make(Entity\User::class)));
+		$this->assertTrue($transformer->supports($this->app->make(Entity\Post::class)));
+		$this->assertFalse($transformer->supports('blabla'));
+	}
+
+	/**
+	 * testTransform
+	 *
+	 * @return void
+	 */
+	public function testTransform() {
+		$user = $this->app->make(Entity\User::class);
+		$transformer = $this->app->make(ModelTransformer::class);
+		$object = $transformer->transform($user);
+		$fields = $object->getFields();
+
+		$this->assertInstanceOf(EloquentObjectType::class, $object);
+		$this->assertSame('User', $object->name);
+		$this->assertSame('A User model representation', $object->description);
+		$this->assertSame($user, $object->getModel());
+
+		foreach (['id', 'name', 'email', 'posts', 'created_at', 'updated_at'] as $field) {
+			$this->assertArrayHasKey($field, $fields);
+		}
+	}
+
+	/**
+	 * testRelationshipColumnArguments
+	 *
+	 * @return void
+	 */
+	public function testRelationshipColumnArguments() {
+		$user        = $this->app->make(Entity\User::class);
+		$transformer = $this->app->make(ModelTransformer::class);
+		$args        = $transformer->transform($user)->getFields()['posts']->config['args'];
+		$assert      = [
+			'after'  => \GraphQL\Type\Definition\IDType::class,
+			'before' => \GraphQL\Type\Definition\IDType::class,
+			'skip'   => \GraphQL\Type\Definition\IntType::class,
+			'take'   => \GraphQL\Type\Definition\IntType::class
+		];
+
+		foreach ($assert as $argument => $type) {
+			$this->assertArrayHasKey($argument, $args);
+			$this->assertInstanceOf($type, $args[$argument]['type']);
+		}
+	}
+
+	/**
+	 * testResolve
+	 *
+	 * @return void
+	 */
+	public function testResolve() {
+		factory(Entity\User::class, 5)->create()->each(function($user) {
+			$user->posts()->saveMany(factory(Entity\Post::class, 5)->make());
+		});
+
+		$builder     = Entity\User::class;
+		$user        = $this->app->make($builder);
+		$entity      = $builder::with('posts')->find(1);
+		$transformer = $this->app->make(ModelTransformer::class);
+		$resolver    = $transformer->transform($user)->getFields()['posts']->config['resolve'];
+		$response    = call_user_func_array($resolver, [$entity, ['take' => 1, 'skip' => 1]]);
+
+		$this->assertSame($entity->posts->get(1)->toArray(), $response[0]->toArray());
+	}
+}