Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FormField messages more flexible #147

Open
jamcry opened this issue Aug 16, 2021 · 1 comment
Open

Make FormField messages more flexible #147

jamcry opened this issue Aug 16, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jamcry
Copy link
Collaborator

jamcry commented Aug 16, 2021

Currently, FormField takes helper and error messages only as strings. We should find a way to make these more flexible because for example in some of the new projects, we need to show icon with error/helper messages:

  helperMessages?: string[];
  errorMessages?: string[];

Example helper message design:
Screen Shot 2021-08-16 at 10 00 02 AM

@jamcry jamcry added the enhancement New feature or request label Aug 16, 2021
@mucahit
Copy link
Contributor

mucahit commented Sep 2, 2021

  • Use React.ReactNode instead of string for message props
  • Create FormFieldLabel (Wrap the label tree) to use in FormField

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants