Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove style-editor-title.css once Gutenberg specificity issues are fixed #125

Closed
nickcernis opened this issue Oct 24, 2018 · 1 comment
Closed

Comments

@nickcernis
Copy link
Collaborator

nickcernis commented Oct 24, 2018

Gutenberg functionality was merged in #121 in a single folder at lib/gutenberg.

Currently, editor styles for the post title live in their own file at lib/gutenberg/style-editor-title.css due to specificity issues with Gutenberg editor styles that prevent the post title being styled via style-editor.css.

This issue is a reminder to adapt and move those styles into lib/gutenberg/style-editor.css once these issues in Gutenberg are resolved (hopefully before WP 5.0 lands):

The title styling currently looks like this:

.editor-post-title__block .editor-post-title__input {
    font-family: 'Source Sans Pro', sans-serif;
    font-size: 30px;
    font-weight: 400;
    line-height: 1.2;
    margin: 0 0 20px;
}

It will need to be changed to this and be moved to style-editor.css once the above issues are solved:

body .editor-post-title__block .editor-post-title__input {
    font-family: 'Source Sans Pro', sans-serif;
    font-size: 30px;
    font-weight: 400;
    line-height: 1.2;
    margin: 0 0 20px;
}

The extra admin stylesheet at lib/gutenberg/style-editor-title.css can then be removed and the require line removed from lib/gutenberg/init.php.

This code in style-editor.css will also need to change once the above issues are resolved:

body[data-align="wide"] {
	max-width: 1092px !important;
}

body[data-align="full"] {
	max-width: none !important;
}

The upcoming proposal to handle wide and full block widths looks like this instead:

.wp-block[data-align="wide"] {
	max-width: 1092px;
}

.wp-block[data-align="full"] {
	max-width: none;
}
@nickcernis
Copy link
Collaborator Author

Completed work on updating Gutenberg editor stylesheet for WP 5.0 Beta 3 / Gutenberg 4.2 changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant