Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with specifying returned classes when generating a Request class #4

Open
SDParish opened this issue Nov 6, 2020 · 0 comments
Open

Comments

@SDParish
Copy link

SDParish commented Nov 6, 2020

In GenerateRequests.php::handleResponse()

Code does (currently line 294)

$response_models[] = "'$code_string' => '$type'";

Except $type has been set as one of:

$type = "\\$model_ns\\$type::class";
$type = "''";

Where the quotation marks are either not wanted, or already included.

I believe the fix should be simply to remove the ' from around $type in the line

$response_models[] = "'$code_string' => '$type'";

referred to above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant