Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop React < 16.3 support #1094

Closed
3 tasks done
sapegin opened this issue Aug 20, 2018 · 6 comments
Closed
3 tasks done

Drop React < 16.3 support #1094

sapegin opened this issue Aug 20, 2018 · 6 comments
Labels
help wanted technical debt
Milestone
9.0.0: New editor

Comments

@sapegin
Copy link
Member

sapegin commented Aug 20, 2018 •
edited
Loading

This will allows us to use the new context API and other new features.

This will be a breaking change, please make a branch based on the next branch.

  • Rewrite context code to use the new API
  • Remove react-lifecycles-compat
  • Update peerDependencies
@sapegin sapegin added this to the 8.0.0: New editor milestone Aug 20, 2018
@rafaesc
Copy link
Collaborator

rafaesc commented Aug 24, 2018

@sapegin can I take it?

@sapegin
Copy link
Member Author

sapegin commented Aug 25, 2018

@rafaesc YES! That would be awesome! ❤️

@rafaesc
Copy link
Collaborator

rafaesc commented Aug 25, 2018

@sapegin Perfect!

@rafaesc
Copy link
Collaborator

rafaesc commented Aug 28, 2018 •
edited
Loading

I was trying to integrate the new context API and in the project works perfect, how I expected, the tests failed, because, I have to change the integration in the tests providing the new context.

But there is an error in dive function of enzyme, when it tries to find the components children.

I found this issue, that it relates

enzymejs/enzyme#1647

If it fixes, tests could pass

I am working with
"enzyme": "^3.5.0",
"enzyme-adapter-react-16.3": "^1.1.0",

@sapegin
Copy link
Member Author

sapegin commented Aug 29, 2018

Thank for investigation!

@rafaesc rafaesc mentioned this issue Aug 29, 2018
Closed
4 tasks
@sapegin
Copy link
Member Author

sapegin commented Oct 31, 2019

Done in 10.0.0!

@sapegin sapegin closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted technical debt
Projects
None yet
Milestone
9.0.0: New editor
Development

No branches or pull requests
2 participants
@sapegin @rafaesc