-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support create-react-app out from the box #191
Comments
I like the idea! Should it be a separate package? What would be its dependencies? |
Yes, it can be a separate package. So far I tried to create this: https://github.com/just-boris/react-app-styleguidist The work is not finished, but I expect that setup instructions in Readme wouldn't be changed. I tried to make that as easy as possible. Implementation details: it uses Styleguidist node API and merges Create-react-app config into current default. Source. |
Looks interesting! Is it possible to use regular Styleguidist config as well? Might be useful though create-react-app has no one ;-) |
What do you mean as "regular config"? |
I mean |
The purpose of my project as well as However, this is a good point. I will add |
I’m not sure it’s really useful if you can’t even change a title of your styleguide ;-) |
Eject could generate a config like that:
|
The title will be picked up from Well, I could make everything working as expected. The The next step will be publishing this into |
Good idea! And feel free to send a pull request to update the docs. |
Related PR into Create React App: facebook/create-react-app#921 |
Cool, thanks! |
CRA is supported in 5.0.0, I’ll send a new PR to CRA later. |
Create React App is a tool to set up react project with good defaults. I am using this for some little short-term project and enjoy configuration-less developer environment.
It would be nice to use
react-styleguidist
the same way: without any configuration, just specified that I am using well-known project setup. Let's say that we should setupdateWebpackConfig
to something like this:The name of this import can be different but the idea is that config doesn't have any options, just one simple
require
instead of the wall of typical setup.So far I could make it working together with the this
styleguide.config.js
.What do you think about putting this into core project to help users to setup styleguides with create-react-app easier?
The text was updated successfully, but these errors were encountered: