phone_number can generate invalid US numbers

[haxney]

I'm using the phone library to parse phone numbers, and it does not allow invalidly-formatted phone numbers. An example is that US area codes are not allowed to start with 1 (and 0, I believe), but Faker will generate numbers with these invalid area codes. Would it be possible to restrict the range of numbers used in generating area codes for Faker phone numbers?

[darrenterhune]

@haxney all you need to do here is set Faker::Config.locale to 'en-us' and add in valid us phone number formats to that i18n locale file as it's not yet implemented ;)

[toobulkeh]

👍 for a Phony/Faker crossover.

[chellberg]

For anyone running into this issue today, you just need Faker::Config.locale = 'en-US' (capitalization matters) - implemented in https://github.com/stympy/faker/blob/master/lib/locales/en-US.yml

[nofxx]

What I did in an application with heavy phone use was Phony validation, as @toobulkeh mentioned.
Just drop those who fail.

[dorianmariecom]

I did:

    phone_number do
      begin
        phone_number = Faker::PhoneNumber.phone_number_with_country_code
        phonelib = Phonelib.parse(phone_number)
      end until phonelib.valid? && phonelib.possible?
      phone_number
    end

[riffraff]

for those hitting this issue, I still see it with the en-US locale and recent versions of phonelib

>> Faker::Config.locale = 'en-US'
=> "en-US"
>> 100.times.map { Phonelib.valid? Faker::PhoneNumber.phone_number_with_country_code }.tally
=> {true=>48, false=>52}

the issue seems to be related to extension numbers, as faker will generate stuff with a literal "x" in it, like +1 210.732.4169 x4399.

You can tell phonelib to accept these, and then it should work

>> Phonelib.extension_separate_symbols = %w(ext x # ;)
=> ["ext", "x", "#", ";"]
>> 100.times.map { Phonelib.valid? Faker::PhoneNumber.phone_number_with_country_code }.tally
=> {true=>100}

[dorianmariecom]

Are those numbers even valid? I will open an issue on phonelib

[dorianmariecom]

>> Phonelib.extension_separate_symbols = %w(ext x # ;)
=> ["ext", "x", "#", ";"]
>> 100.times.map { Phonelib.valid? Faker::PhoneNumber.phone_number_with_country_code }.tall
y
=> {false=>97, true=>3}