Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Currency Symbol to Faker #1201

Merged
merged 2 commits into from
May 20, 2018
Merged

Adding Currency Symbol to Faker #1201

merged 2 commits into from
May 20, 2018

Conversation

SaimonL
Copy link
Contributor

@SaimonL SaimonL commented May 4, 2018

Adding Currency Symbol to Faker.

vbrazo
vbrazo requested changes May 16, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaimonL Looks good 🥇 We should rebase with master before merging.

@vbrazo vbrazo force-pushed the master branch 2 times, most recently from 1dbe328 to e1e54c6 Compare May 20, 2018 02:35
@vbrazo vbrazo merged commit 2998b45 into faker-ruby:master May 20, 2018
@vbrazo
Copy link
Member

vbrazo commented May 20, 2018

Merged successfully 👍

@vbrazo vbrazo self-requested a review July 19, 2018 01:26
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@SaimonL @vbrazo
Adding Currency Symbol to Faker (faker-ruby#1201)
2e5e6d9 
* Adding Currency Symbols very useful for E-Commerce websites.

* Unit test (don't know unit test only only RSPEC test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo Awaiting requested review from vbrazo

Assignees

@SaimonL SaimonL

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaimonL @vbrazo