Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate capital city of random Nation #1247

Merged
merged 5 commits into from
May 25, 2018
Merged

Generate capital city of random Nation #1247

merged 5 commits into from
May 25, 2018

Conversation

gkunwar
Copy link
Contributor

@gkunwar gkunwar commented May 24, 2018

This PR gives:

  • Capital city of random Nation

Here is issue link: #1242

@gkunwar
Copy link
Contributor Author

gkunwar commented May 25, 2018

@vbrazo @stympy can you please check this PR?

@stympy stympy merged commit ed0b9e6 into faker-ruby:master May 25, 2018
@stympy
Copy link
Contributor

stympy commented May 25, 2018

@gkunwar Thanks!

@gkunwar gkunwar deleted the capital_city branch May 25, 2018 17:42
@gkunwar
Copy link
Contributor Author

gkunwar commented May 25, 2018

Your are welcome @stympy :)

davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants