Prepare Faker::Name.job_titles and Faker::Name.title for deprecation #1264
Conversation
|
@mrstebo when you update the |
|
@vbrazo Done! Everything look okay? |
|
@stympy how do we display the deprecation message in the Faker gem? |
|
I suppose we could use Gem::Deprecate. The year and month should be September 2018. |
|
@stympy @vbrazo I added Should these be left in so that we know what needs to change before the methods are removed? Or do we add in a before hook into the tests to suppress these warnings? Personally, I'd prefer to keep these warnings in there. Gives a bigger incentive for someone to come along and fix the warnings 🤔 |
vbrazo
force-pushed
the
refactor/prepare-job-titles-for-deprecation
branch
from
733adbe
to
78c316f
Compare
…aker-ruby#1264) * Added additional levels of seniority. * Using Faker::Job to return a job title. * Making job_titles fetch the list of jobs from the jobs data file. * Removed the title section from the name data file. * Removed methods from Faker::Name documentation. * Added Deprecation section to the changelog with a link to the PR. * Added Gem::Deprecate to show warnings of deprecated methods. * Remove Rubygems deprecation warnings
As mentioned in #1256 we should not take away the job-like methods from
Faker::Namestraight away. Instead we should add deprecation warnings.Could you offer some advise on how we are notifying consumers of the deprecation, and then I'll make the appropriate changes?
Faker::Namedocumentation?