Rename Internet#user_name to #username #1306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call me pedantic, but this—by far—has always been my biggest gripe with Faker. "Username" is the more typical and standardized spelling. I always seem to end up with code like this:
Having to remember that difference for this one library (and put up with the misalignment to boot 😉) is a constant source of frustration. Here's what that code would look like now:
Ah, much improved!
I've added an alias to maintain backwards compatibility.