Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::Construction #1341

Merged
merged 5 commits into from
Aug 28, 2018
Merged

Add Faker::Construction #1341

merged 5 commits into from
Aug 28, 2018

Conversation

benwyrosdick
Copy link
Contributor

The Construction class adds data useful for describing construction projects. This iteration includes methods for getting building materials (material) and subcontract categories (subcontract_category).

@vbrazo vbrazo changed the title add a Construction class Add Faker::Construction Aug 22, 2018
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Thanks 👍

end

def test_subcontract_category
10.times { assert Faker::Construction.material.match(/[\w]+/) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to run this test 10 times.

@@ -0,0 +1,11 @@
# Faker::Construction

Available in future versions of faker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbrazo vbrazo merged commit 153321d into faker-ruby:master Aug 28, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* add materials

* add subcontract_category

* add docs

* Update CHANGELOG.md

* Update test_faker_construction.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants