-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Faker::Construction #1341
Add Faker::Construction #1341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Thanks 👍
test/test_faker_construction.rb
Outdated
end | ||
|
||
def test_subcontract_category | ||
10.times { assert Faker::Construction.material.match(/[\w]+/) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to run this test 10 times.
@@ -0,0 +1,11 @@ | |||
# Faker::Construction | |||
|
|||
Available in future versions of faker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* add materials * add subcontract_category * add docs * Update CHANGELOG.md * Update test_faker_construction.rb
The
Construction
class adds data useful for describing construction projects. This iteration includes methods for getting building materials (material
) and subcontract categories (subcontract_category
).