Add Faker::Finance.vat_number #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tagliala hey brother. Could you please take a look at this PR and let me know how it looks? |
tagliala
suggested changes
Aug 28, 2018
| SI: "SI########" | ||
| SK: "SK##########" | ||
| SM: "SM#####" | ||
| UA: "UA##########" |
There was a problem hiding this comment.
Missing new line at the end of file
There was a problem hiding this comment.
Thanks for the heads up 👍
| # the sum plus whatever the last digit is must be a multiple of 10. So, the | ||
| # last digit must be 10 - the last digit of the sum. | ||
| luhn_digit = (10 - (luhn_sum % 10)) % 10 | ||
|
|
||
| template.gsub('L', luhn_digit.to_s) | ||
| end | ||
|
|
||
| def vat_number(country = 'BR') |
There was a problem hiding this comment.
Is there a reason for the default country to be BR?
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add Faker::Finance.vat_number, its tests and docs * Update changelog * Add tests and reorder locales * Minor changes * Update test_faker_finance.rb * Minor change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR fixes #1326