Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faker::Types minor cleanup #1362

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Faker::Types minor cleanup #1362

merged 2 commits into from
Sep 14, 2018

Conversation

stephengroat
Copy link
Contributor

No description provided.

@vbrazo vbrazo added the Chores label Sep 14, 2018
vbrazo
vbrazo approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Thanks for refactoring the types module.

You forgot to update the doc/types.md. Just update the docs and we'd be good to go.

@vbrazo vbrazo changed the title Minor code reuse cleanup Faker::Types minor cleanup Sep 14, 2018
@vbrazo
Copy link
Member

vbrazo commented Sep 14, 2018

It'd be great if you could add examples in the docs with params and without params.

@vbrazo
Copy link
Member

vbrazo commented Sep 14, 2018

Thanks!

@vbrazo vbrazo merged commit a57fe15 into faker-ruby:master Sep 14, 2018
@stephengroat stephengroat deleted the code-cleanup branch September 14, 2018 18:28
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@stephengroat @vbrazo
Faker::Types minor cleanup (faker-ruby#1362)
4c81f7d 
* Minor code reuse cleanup

* added examples to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@stephengroat stephengroat

Labels
Chores
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephengroat @vbrazo