Add Faker::Music::Phish #1387
Merged
Add Faker::Music::Phish #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Song list taken from Phish Wikipedia page: https://en.wikipedia.org/wiki/List_of_songs_recorded_by_Phish
vbrazo
approved these changes
Oct 10, 2018
|
@vbrazo Sure thing. Would you like me to take a shot at adding other music modules to the namespace (ex. Umphrey's McGhee)? I'll update when I get home from work. |
|
If they're new modules of other bands, I'd prefer to have these new modules in other PRs. The answer is yes. Feel free to contribute. |
vbrazo
reviewed
Oct 26, 2018
README.md
Outdated
| @@ -130,6 +130,7 @@ Contents | |||
| - [Faker::OnePiece](doc/one_piece.md) | |||
| - [Faker::Overwatch](doc/overwatch.md) | |||
| - [Faker::ParksAndRec](doc/parks_and_rec.md) | |||
| - [Faker::Phish](doc/phish.md) | |||
There was a problem hiding this comment.
We've just changed the README.md and now it should have only objects that are in the v1.9.1. You need to update the unreleased_CONTENT.md instead.
There was a problem hiding this comment.
Sounds good. Sorry for the delay. I'll update today.
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add Phish Song list taken from Phish Wikipedia page: https://en.wikipedia.org/wiki/List_of_songs_recorded_by_Phish * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for maintaining this gem.
Song list taken from Phish Wikipedia page:
List of songs recorded by Phish