Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Games::Heroes #1413

Merged
merged 6 commits into from
Oct 17, 2018
Merged

Add Faker::Games::Heroes #1413

merged 6 commits into from
Oct 17, 2018

Conversation

tangens
Copy link
Contributor

@tangens tangens commented Oct 16, 2018

Add "Heroes 3" heroes names, specialities and classes

Artjoms Tanigins added 2 commits October 16, 2018 11:42
vbrazo
vbrazo reviewed Oct 16, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Heroes3 is a game, right?

If so, could you wrap this new object in the Games namespace: Faker::Games::Heroes?

doc/heroes.md Outdated
```ruby
Faker::Heroes.name #=> "Christian"

Faker::House.specialty #=> "Ballista"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faker::House copy and 🍝

doc/heroes.md Outdated

Faker::House.specialty #=> "Ballista"

Faker::House.klass #=> "Knight"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faker::House copy and 🍝

@tangens
Copy link
Contributor Author

tangens commented Oct 17, 2018

@vbrazo putted under "Games"

@vbrazo vbrazo changed the title Add heroes3 Add Faker::Games::Heroes Oct 17, 2018
vbrazo
vbrazo approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks 👍

@vbrazo vbrazo merged commit 84b18ee into faker-ruby:master Oct 17, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@tangens @vbrazo
Add Faker::Games::Heroes (faker-ruby#1413)
1c376fe 
* add heroes3

* Add readme

* Move heroes under games module

* remove trailing whitespaces for rubocop

* Update README.md

* Update heroes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@tangens tangens

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tangens @vbrazo