Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've been working in this repo, I noticed the test for this code was being skipped. On investigation, it was because this generator was not truly accurate, and the test would occasionally fail (as it should have)
The generator would create a final digit for the generated number, but did not handle the edge cases when this 'check digit' was 10 or 11.
In the case when the check digit is 10, the entire number is invalid. In this situation, I subtracted one from the generated number which would then be guaranteed to be a valid number.
In the case when the check digit is 11, it should be returned as a 0, not as 11.
Rules were read from the wikipedia page that was linked in the original PR that introduced this faker.
These changes have tests, and the original test that set me onto this problem is no longer omitted, and should be consistently passing now.