Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex and add magic string to pass rubocop check #1436

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Fix regex and add magic string to pass rubocop check #1436

merged 1 commit into from
Oct 22, 2018

Conversation

jakrzus
Copy link
Contributor

@jakrzus jakrzus commented Oct 22, 2018

Small fix to pass Rubocop checks

@jakrzus jakrzus mentioned this pull request Oct 22, 2018
Closed
vbrazo
vbrazo approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vbrazo vbrazo merged commit 25b9031 into faker-ruby:master Oct 22, 2018
@jakrzus jakrzus deleted the Fixes_faker_phone_number_regex branch October 22, 2018 22:06
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@jakrzus @vbrazo
Fix regex and add magic string to pass rubocop check (faker-ruby#1436)
3df7c41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@jakrzus jakrzus

Labels
🐞 Issue: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakrzus @vbrazo