Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::Marketing #1460

Merged
merged 7 commits into from
Nov 5, 2018
Merged

Conversation

susiirwin
Copy link
Contributor

This PR is a new module for Marketing Buzzwords that I hear all too often. It includes:

  • faker
  • test
  • md file with example strings

@vbrazo
Copy link
Member

vbrazo commented Nov 2, 2018

Besides that you need to update the unreleased_CONTENT.md.

@vbrazo
Copy link
Member

vbrazo commented Nov 2, 2018

I think this object could be named as Faker::Marketing. What do you think? It'd be a bit better because we could include lots of other methods.

@susiirwin
Copy link
Contributor Author

that is a great idea!!!

Updates all related files to be a more generic Marketing so more
methods can be added in the future.
@vbrazo vbrazo changed the title Marketing buzzwords Add Faker::Marketing Nov 3, 2018
@vbrazo vbrazo merged commit 62b5857 into faker-ruby:master Nov 5, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Begin development of marketing buzzwords

* Adds a few more phrases

* Adds a few more buzzwords, adds a yml and updates the documentation

* moved md to unreleased and updated it

* add module to unreleased_CONTENT.md

* Updates to be Marketing

Updates all related files to be a more generic Marketing so more
methods can be added in the future.

* Update marketing.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants