-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix name_with_middle field for en-AU #1559
Conversation
This isn’t right... name_with_middle is a sibling to name, not a child. |
@stympy That's not the case with other files. Example files I found it opposite:
to name a few.. |
Are we looking at the same thing?
|
@stympy Let's take the You can see that |
Ah, looking at it again, I see I misunderstood the context of the change. Yes, line 10 should be changed as in the patch, but line 11 should not be. |
@stympy Reg line 11, yeah you're right. But according to YAML specification - that should also work. But I can change that if you would prefer not changing that. |
Yeah, it would work, but it doesn't match the existing style. Please revert line 11 and this will be good to go. Thanks! |
@stympy Pushed a new commit. I hope that works. |
Perfect, thanks! |
The name_with_middle should be under the name field.